Skip to content

Conversation

chrisbobbe
Copy link
Contributor

…n startup

This is a new incarnation of the same underlying React Native
issue seen in 8f8a266 and 833d083, back in 2019 and 2018
respectively.  RN hard-codes what intermediate directory it
expects the Android Gradle Plugin to look for assets in; but that
directory isn't any kind of stable API, and in fact it changes
from time to time in new versions of AGP.  It changed again
in AGP 7.1.0.

More recent versions of RN know about this latest change (with yet
another hardcoding, conditioned on a new range of AGP versions):
  facebook/react-native#33057
But ours doesn't, because we haven't been updating RN for a while in
this legacy codebase.  So just update the directory we force it to.

See discussion:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/release.20build.20missing.20JS.20bundle/near/1746718

[greg: expanded commit message]
@gnprice gnprice force-pushed the pr-missing-js-bundle-fix branch from d76e7dc to eb56300 Compare February 27, 2024 22:12
@gnprice gnprice merged commit eb56300 into zulip:main Feb 27, 2024
@gnprice
Copy link
Member

gnprice commented Feb 27, 2024

Thanks! Expanded the commit message, and merging.

@chrisbobbe chrisbobbe deleted the pr-missing-js-bundle-fix branch February 27, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants