android: Update targetSdkVersion to 33 (Android 13) #5749
Conversation
This change will be required in order to upload new releases to the Play Store, effective 2023-08-31 (or 2023-11-01 if we request an extension). This change causes Android 13 and later to apply to our app a number of behavior changes introduced in that version, documented here: https://developer.android.com/about/versions/13/behavior-changes-13 The "Granular media permissions" section stood out as potentially relevant -- until we remembered that, in PR zulip#5618, we upgraded react-native-image-picker such that on Android 13+ we use Android's PhotoPicker API. With that API, the app learns about just the images that the user selects, in a separate media picker, so our app code doesn't need direct access to whole lists of media created by other apps. That's what this note in that section of the doc is about: > Note: If your app only needs to access images, photos, and videos, > consider using the photo picker instead of declaring the > READ_MEDIA_IMAGES and READ_MEDIA_VIDEO permissions. Fixes: zulip#5453
|
Tested on my Pixel 5 running Android 13, and it seems to work fine. In particular I tested both "attach photo from library" and "use camera" — since that was one area where the docs indicated things were changing, which we looked at in the office on Friday — and both worked fine. I suppose the other thing we need to do is to read through the list of potentially-breaking changes and confirm we don't see anything else that seems like it might affect us. I saw you'd looked through at least some of those docs on Friday. Do you have any notes on things you spotted? |
|
The short answer is that I read through the whole doc, and I don't think anything in there is likely to be disruptive. In a section "Battery Resource Utilization", it mentions the system broadcasts There is a section "App color theme applied automatically to WebView content" about a For the "Updated non-SDK restrictions" section, a linked doc says any issues of that kind would show up in the Play Console, and I checked and didn't see any. |
|
Cool, thanks. And I just read through it as well: #5453 (comment) and don't see anything else of interest. I did just test this in dark theme as well as light theme, and all still worked as desired. LGTM; merging! |
This change will be required in order to upload new releases to the Play Store, effective 2023-08-31 (or 2023-11-01 if we request an extension).
Tested on an emulated Pixel running Android 13, but testing on a real device would be good too. (The office device I use only runs Android 9, though, so I can't do that myself.)
Fixes: #5453