-
-
Notifications
You must be signed in to change notification settings - Fork 673
tools: Refactor finding changed files; fix tools/test prettier --all
on .js.flow files
#5547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! One thought I had while reading this: are we still applying this workaround correctly in
I think we are, from looking through |
Good question. I wasn't actually thinking about that when I wrote these changes. But rereading them now, I think none of them affect it. Merging; thanks for the review! |
We have other scripts that print other kinds of information. This one is about information from Git.
This is NFC because none of our scripts currently pass any arguments at all to `tools/info changed-files`.
This lets Git do more of the work, and should be a bit more efficient.
This makes the name a bit shorter, before we start calling it in more places.
This makes existing callsites a bit longer, but lets us simplify some other commands by switching to `tools/git changed-files`.
This makes all the suites' runners parallel to each other in shape.
This better juxtaposes this function's logic with other things its caller is doing... which brings into view a bug where they don't agree.
6eef90e
to
6ca7122
Compare
The tip of this branch fixes #5546. The rest is a series of NFC refactors that lead up to the fix, and/or were inspired by looking at that logic.
Fixes: #5546