deps: Follow @babel/runtime upgrade from RN template app. #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking the RN v0.63 upgrade issue, #4245. |
Closed
Part of the RN v0.62 -> v0.63 changes to the template app [1], corresponding to facebook/react-native@82e823933. That RN commit upgrades a few other deps; we don't take those changes, for the following reasons: - We're already past ^7.6.2 of @babel/core. - We don't currently use @react-native-community/eslint-config (though we're considering it, in zulip#4119). - We don't currently use babel-jest. - We're already past ^25.1.0 of jest. - We're already past ^0.58.0 of metro-react-native-babel-preset. Run our usual `yarn yarn-deduplicate && yarn`, as prompted by `tools/test deps`. [1] https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4
de252fb to
b1cd21e
Compare
|
Looks good, merged -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the RN v0.62 -> v0.63 changes to the template app [1],
corresponding to facebook/react-native@82e823933.
That RN commit upgrades a few other deps; we don't take those
changes, for the following reasons:
We're already past ^7.6.2 of @babel/core.
We don't currently use @react-native-community/eslint-config
(though we're considering it, in Add and enable
@react-native-community/eslint-config. #4119).We don't currently use babel-jest.
We're already past ^25.1.0 of jest.
We're already past ^0.58.0 of metro-react-native-babel-preset.
Run our usual
yarn yarn-deduplicate && yarn, as prompted bytools/test deps.[1] https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.4