Update to target Android 10 / API 29. #4282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This opts out of Android 10's new "scoped storage" model. Docs: https://developer.android.com/training/data-storage/use-cases#opt-out-scoped-storage The new model otherwise takes effect on Android 10+ devices when targeting Android 10+. We're about to start targeting Android 10 (zulip#3665), because Google Play will require us to do so starting on 2020-11-02, which is soon. The opt-out will stop having any effect on Android 11+, when we eventually target Android 11+. So effectively it gives us an extension of one more cycle on adapting to the new model. The reason we're opting out is that at least one of our dependencies, the react-native-image-picker library which we use for taking photos and also picking existing photos to share on Zulip, hasn't yet adapted to work properly with scoped storage; if you try doing so in a Zulip that targets Android 10 but doesn't have this change, you just get an error. I've filed zulip#4283 with details of the issue and what needs to be done to properly fix it.
This change will be required in order to upload new releases to the Play Store, effective 2020-11-01, a couple of weeks from now. The change causes Android 10 and later to apply to our app a number of behavior changes introduced in that version, documented here: https://developer.android.com/about/versions/10/behavior-changes-10 After reading carefully through that documentation, I believe we can rule out almost all the changes as possibly affecting us: zulip#3665 (comment) except for one -- "scoped storage" -- and it seems likely that the remaining don't either. We've opted out of scoped storage for now, in the previous commit. We'll want to thoroughly test a beta version with this change before shipping it broadly, to try to catch any remaining issues. Fixes: zulip#3665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will be required in order to upload new releases to the
Play Store, effective 2020-11-01, a couple of weeks from now.
The change causes Android 10 and later to apply to our app a number
of behavior changes introduced in that version, documented here:
https://developer.android.com/about/versions/10/behavior-changes-10
Further discussion in #3665.
Fixes: #3665