ComposeMenu: Offer file picker on iOS, not just Android. #4935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Inheriting P1 from the issue. |
2b8058d to
e295249
Compare
e295249 to
f3293d4
Compare
|
Thanks for pushing on this! The code looks great.
Hmm, that seems like a pretty bad symptom -- it's likely to make the user think it didn't work at all. I'll go take a look at #5635 now and see if we can merge that first. |
|
OK, just reviewed #5635. Not quite ready to merge, but I think we'll be able to do so soon. So let's let this PR just hang out for a bit, and we can merge it once that's in. |
|
OK, and #5635 is now merged. Would you rebase this PR and resolve the conflicts? |
Because it's been a while since we upgraded it, and because upgrading came up in a not-so-recent discussion of opting into the iOS side of this library, in zulip#4586. The release notes announce some breaking changes, but those shouldn't affect us: - A few changes to `fileCopyUri`, but we don't use that - A change to `pick`, which we don't use (we use `pickMultiple`) - Desupport Android <5 (which we've already done) Changelog: https://github.com/rnmods/react-native-document-picker/releases
I've just tested on my iPhone (13 Pro, running iOS 16.1), and I was able to upload a file just fine after this change. That was easy! Fixes: zulip#4586
I don't get any warnings from Jest with this usual style of import. It looks like r-n-document-picker handled that in react-native-documents/document-picker#474 , first released in v6.0.5. We upgraded past that version a few commits ago.
f3293d4 to
1c891b9
Compare
|
Sure, revision pushed. Here's a screen recording: |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComposeMenu: Offer file picker on iOS, not just Android
I've just tested on my iPhone (13 Pro, running iOS 16.1), and I was
able to upload a file just fine after this change. That was easy!
Fixes: #4586
cc @alya for the UX change
(edited for revision on 2023-01-10; screenshots in a later message)