Skip to content

Migrate to community ViewPagerAndroid #3569

@gnprice

Description

@gnprice

This is a followup to the RN v0.59 upgrade #3399. It will be required for an RN v0.61 upgrade when that's out, but isn't required for v0.60.

When launching the app with the debugger, the following message now goes to the console:

Warning: ViewPagerAndroid has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/viewpager' instead of 'react-native'. See https://github.com/react-native-community/react-native-viewpager

In v0.60, the core module is still there; but it's gone in master since facebook/react-native@f8a400a, which will presumably be in v0.61.

The README doesn't say much about upgrading; hopefully it's smoothly compatible.

At a quick grep, we don't refer to this module ourselves:

$ rg ViewPagerAndroid
$

But it's used in react-native-tab-view:

$ rg ViewPagerAndroid node_modules/
...

Which in turn is pulled in by react-navigation, and I'm guessing is used for the tab navigators.

So most likely what this will come down to is upgrading react-navigation, aka #3573. We're still on a ^1 version; we have partial work in #2702 and #3502 to move to ^2 and then ^3, which is the latest.

Metadata

Metadata

Assignees

No one assigned

    Labels

    blocked on other workTo come back to after another related PR, or some other task.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions