Skip to content

bump to crystal 1.0.0 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bump to crystal 1.0.0 #7

wants to merge 1 commit into from

Conversation

mearsten
Copy link

@ysbaddaden
Copy link
Owner

Thanks. You can relax the minitest constraint to just ~> 1.0.

Isn't crystal: ">= 1.0" also needed?

@kostya
Copy link

kostya commented Mar 30, 2021

yes, need such line: crystal: ">= 1.0.0, < 2.0" or crystal: ">= 0.35.1, < 2.0", and btw is not shard.lock not used, and not needed here, just to be in gitignore.

@mearsten
Copy link
Author

Thanks. You can relax the minitest constraint to just ~> 1.0.

Fixed.

Isn't crystal: ">= 1.0" also needed?

Thank you Julien, I added that too.

@mearsten
Copy link
Author

and btw is not shard.lock not used, and not needed here, just to be in gitignore.

Do you mean that shard.lock should not be kept in git?

@mearsten mearsten changed the title bump shard.lock to v2.0 bump to crystal 1.0.0 Mar 30, 2021
@kostya
Copy link

kostya commented Apr 1, 2021

I think this can be merged, many projects related on pool repo. Shard.lock can be removed later

@mearsten
Copy link
Author

mearsten commented Apr 2, 2021

many projects related on pool repo

Yes. At least crystal-redis depends.

@ysbaddaden
Copy link
Owner

ysbaddaden commented Apr 8, 2021

Thanks for bump. I used crystal: *, which should have been the actual default, and the library didn't any fix since 2016 (aka forever). I released v0.2.4 which is identical the v0.2.3, except shards now considers it (sigh).

@ysbaddaden ysbaddaden closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants