Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

Conversation

SuhasDissa
Copy link
Member

This PR is pretty self-explanatory. The screenshots will show you what's new.


@Bnyro
Copy link
Member

Bnyro commented Jul 20, 2023

Looks great!

One thing though:
Do we really need to use a constraint layout and can't just add a normal row/column where one component uses Modifier.weight(1f)?
In my opinion we should try to keep things simple, and the new dependency is not really needed in my eyes.

So I'd just replace the constraintAs modifier and use a Row for landscape and a Column for portrait instead of a Box in ResponsiveRecordScreenLayout.

@SuhasDissa
Copy link
Member Author

My initial plan was to do it like that. But Thought of using constraint layout for better flexibility.
I too think thats a bit overkill for this simple scenario.

@SuhasDissa
Copy link
Member Author

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you! <3

@Bnyro Bnyro merged commit 710911b into you-apps:main Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants