Allow filtering of individual accounts #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06614dd to
0ca9f81
Compare
The existing behaviour toggles all accounts from a single provider when one of them is selected in the filter dialog. This change means selections are managed by account name rather than type, in order to allow filtering on individual accounts.
|
Just taking a peek at this, I'd suggest putting the account name before the type in the UI (or even omit the type?), as the types are quite long and the horizontal scrolling really doesn't make it easy to select the desired accounts: (the full text of these DAVx5 accounts are of the form Both account types and groups here probably ought to be vertical lists (with the whole dialog scrollable) -- I can put that in a separate issue if you want to track that. The filters don't seem to be selectable at all any more, but I assume that's still being worked on... |
|
It's broken currently, feel free to take my changes and create a new PR, or I'll see if I can get it running some day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behaviour toggles all accounts from a single provider when one of them is selected in the filter dialog.
This change means selections are managed by account name rather than type, in order to allow filtering on individual accounts.
I had to open a new PR because #238 blocked write access.