Implement Model Context Protocol (MCP) server for protolint #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add protocol definitions in `mcp/protocol.go` for JSON-RPC requests and responses. - Create unit tests for protocol handling in `mcp/protocol_test.go`. - Develop the MCP server logic in `mcp/server.go`, including request handling and tool execution. - Implement tools interface and linting functionality in `mcp/tools.go`, with a specific tool for linting Proto files. - Add tests for the linting tool in `mcp/tools_test.go`. - Create a new executable file `protolint` for running the MCP server.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the Model Context Protocol (MCP) server mode in protolint, enabling direct interaction with AI models.
- Implements a new MCP server with corresponding tools and reporters.
- Integrates a new --mcp flag in the command-line interface and updates the README and MCP documentation.
- Enhances the codebase with a LintRunner interface and registers a new CmdLintRunner for CMD operations.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mcp/tools.go | Introduces the LintFilesTool with Execute method for MCP tooling. |
| mcp/server.go | Implements the MCP server and request handling for MCP methods. |
| mcp/protocol.go & mcp/protocol_test.go | Defines JSON-RPC protocol types and tests their correct (un)marshaling. |
| mcp/README.md | Adds documentation describing MCP usage and integration with Claude. |
| internal/cmd/cmd.go & related files | Integrates the new --mcp flag to start the MCP server. |
| lib/lint.go & lib/lint_test_runner.go | Sets a flexible LintRunner interface and registers a mock/test runner. |
| internal/linter/report/reporters/mcpReporter* | Implements and tests the MCPReporter for formatting lint results in JSON. |
Comments suppressed due to low confidence (1)
mcp/tools.go:115
- Verify whether the JSON output from the MCP reporter is expected to be written to stderr. If the reporter writes to stdout, consider using outputBuffer instead of errorBuffer for JSON unmarshalling.
if err := json.Unmarshal(errorBuffer.Bytes(), &result); err != nil {
- Added usage instructions for MCP clients in README.md. - Introduced a new demo GIF for Claude Desktop integration. - Updated MCP server implementation to support JSON-RPC 2.0 communication. - Revised server capabilities and instructions for clarity. - Modified tool interface to use 'any' type for better flexibility. - Improved lint-files tool descriptions and added user guidance for fixing errors. Close #468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to
protolint, including the addition of Model Context Protocol (MCP) server functionality, a new MCP reporter, and related documentation updates. These changes enableprotolintto integrate with AI tools like Claude Desktop and provide structured linting results in MCP-friendly formats.New MCP Server Functionality:
protolintto act as an MCP server for AI model integration (internal/cmd/cmd.go,mcp/README.md,README.md). [1] [2] [3]--mcpflag to start the MCP server and handle requests via stdin/stdout (internal/cmd/cmd.go). [1] [2] [3]New MCP Reporter:
MCPReporterto output linting results in a JSON format compatible with MCP (internal/linter/report/reporters/mcpReporter.go).mcpreporter (internal/cmd/subcmds/lint/reporterFlag.go). [1] [2]Code Refactoring and Extensibility:
LintRunnerinterface, enabling better modularity and testability (lib/lint.go,lib/lint_test_runner.go,internal/cmd/lint_runner.go). [1] [2] [3]Documentation Updates:
mcp/README.md,README.md). [1] [2]Testing:
MCPReporterto validate its JSON output and ensure compatibility with MCP clients (internal/linter/report/reporters/mcpReporter_test.go).