Skip to content

Fix crash on saving endpoint (FFUF related only) #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 27, 2023
Merged

Fix crash on saving endpoint (FFUF related only) #1063

merged 9 commits into from
Nov 27, 2023

Conversation

psyray
Copy link
Contributor

@psyray psyray commented Nov 22, 2023 •
edited
Loading

Fix #1006

I've added :

  • a try except block to catch error on duplicate record returned by get_or_create in saving_endpoint method
  • a check on endpoint existence in dir_file_fuzz method

Errors are logged to the console with the URL.

image

Tested and working

Now we need to find why there are duplicates endpoints in the db
But it's another issue

@psyray psyray self-assigned this Nov 22, 2023
@psyray psyray mentioned this pull request Nov 22, 2023
Closed
1 task
AnonymousWP
AnonymousWP previously approved these changes Nov 22, 2023
View reviewed changes
@psyray
Copy link
Contributor Author

psyray commented Nov 22, 2023

@AnonymousWP
Discussed with @ocervell, we must prevent empty endpoint return.
So I have reworked the fix to :

  1. Check if endpoint exists
  2. If exists, get only the first one
  3. Not exists, create new

In both case an endpoint is returned.

@psyray psyray mentioned this pull request Nov 22, 2023
Merged
1 task
yogeshojha
yogeshojha previously approved these changes Nov 24, 2023
View reviewed changes
Copy link
Owner

@yogeshojha yogeshojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

AnonymousWP
AnonymousWP suggested changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See open conversation.

@psyray
Copy link
Contributor Author

psyray commented Nov 25, 2023

See open conversation.

Done

@psyray psyray requested a review from AnonymousWP November 25, 2023 16:36
yogeshojha
yogeshojha approved these changes Nov 27, 2023
View reviewed changes
Copy link
Owner

@yogeshojha yogeshojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yogeshojha yogeshojha merged commit 2e089dc into yogeshojha:master Nov 27, 2023
@psyray psyray deleted the fix-1006-db branch December 11, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogeshojha yogeshojha yogeshojha approved these changes

+1 more reviewer

@AnonymousWP AnonymousWP AnonymousWP approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@psyray psyray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 2, "Directories & files fuzz - In progress" Never stop
3 participants
@psyray @yogeshojha @AnonymousWP