Add a check to not load datatables twice #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshojha
previously approved these changes
Nov 16, 2023
|
Looks good to me! |
|
I've added also on the Visualization tab. |
AnonymousWP
previously approved these changes
Nov 21, 2023
|
@psyray Check the commit I've pushed (to solve a merge conflict). Let me know if it's okay now, so I can approve. |
yogeshojha
approved these changes
Nov 21, 2023
AnonymousWP
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1038
Add a check to not load DT twice for subdomains and vulnerabilities.
Table config is really complex and it's the quickest way to fix this.
Also it doesn't need to load table on each tab click, so it saves a lot of bandwidth on huge project
I've add a reload button on the vulnerabilities table, like the one in subdomains.