-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
Endpoints list is not good.
In one of my project, on the dashboard page of a scan, I could see this
When I display the endpoints menu in a given scan view, I have a lot of GF hint but when I click on them, list is empty
After further investigation, it looks like the query used to get them all for the list is not good
Line 2119 in c145bec
endpoints_obj = EndPoint.objects.filter(target_domain__project__slug=project) |
Filter is restrict to project slug, instead of scan id
When I replaced it by scan_id, list is good
Also, the same problem is present on the Target page, count is not good.
It should be the overall count of all the scan, but here, only 13 endpoints is here, which is the subdomains count.
I have a look in the db and the target_subdomain_id is missing from all the endpoints without the is_default flag set to true
So it could be complicated to list all the endpoint in the target tab if the target_domain_id is missing.
I think a scan is not correctly filling this value
I will investigate more to find the issue
Expected Behavior
Endpoints count and list must be good
Steps To Reproduce
- Add a target
- Scan target
- Scan subdomains for endpoints
Environment
- reNgine: 2.0.1
- OS: Debian 12
- Python: 3.10
- Docker Engine: 24.0.7
- Docker Compose: 2.5.0
- Browser: FF 119
Anything else?
No response