Skip to content

Conversation

kevinburke
Copy link
Contributor

Previously if you tried to read a HostName in a config file that
looked like this:

Host github
    HostName github.com        # This is the host for code review

DefaultUserSettings.Get("HostName") would return "github.com ",
which I think is unintuitive and unexpected.

This behavior is fixed in v1.2 which would return "github.com" in the
above example.

This rearranges the file a little bit, but none of the dependencies
are changed.
Previously if you tried to read a HostName in a config file that
looked like this:

```
Host github
    HostName github.com        # This is the host for code review
```

DefaultUserSettings.Get("HostName") would return "github.com        ",
which I think is unintuitive and unexpected.

This behavior is fixed in v1.2 which would return "github.com" in the
above example.
@yinheli yinheli merged commit e738afe into yinheli:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants