Skip to content

Feat/dockerfile #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2023
Merged

Feat/dockerfile #15

merged 3 commits into from
Dec 18, 2023

Conversation

kenwoodjw
Copy link
Contributor

support docker

yihong0618
yihong0618 reviewed Dec 17, 2023
View reviewed changes
Dockerfile Outdated
Comment on lines 9 to 15
# 设置环境变量，使得 Python 包安装程序可以找到 gdal-config
ENV CPLUS_INCLUDE_PATH=/usr/include/gdal
ENV C_INCLUDE_PATH=/usr/include/gdal
# Copy necessary files
COPY requirements.txt ./
RUN pip install --upgrade pip && pip install --no-cache-dir -r requirements.txt
# 复制项目文件到容器中
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better in English, since we have other language users

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Dockerfile Outdated
# 复制项目文件到容器中
COPY *.py .
COPY handlers /app/handlers
ENV GOOGLE_GEMINI_KEY=your_google_gemini_apikey
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we passed ENV this way some newbie will push the token to GitHub...we'd better to pass it in docker run....
@frostming what do you think.

@yihong0618 yihong0618 merged commit 6e0ae56 into yihong0618:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihong0618 yihong0618 yihong0618 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenwoodjw @yihong0618