Skip to content

fix crash in storage/groups #11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix crash in storage/groups #11268

merged 1 commit into from
Nov 5, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Nov 5, 2024

Changelog entry

fix crash in storage/groups - access of already released memory
closes #11263

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

@adameat adameat requested a review from a team as a code owner November 5, 2024 10:10
@github-actions github-actions bot added the bugfix label Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

⚪ 2024-11-05 10:14:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 79ac3e3 has started.
⚪ 2024-11-05 10:14:14 UTC Artifacts will be uploaded here
⚪ 2024-11-05 10:17:23 UTC ya make is running...
🟡 2024-11-05 11:01:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14929 13428 0 3 1404 94

⚪ 2024-11-05 11:02:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-05 11:14:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 4 0 0 1 92

🟢 2024-11-05 11:14:22 UTC Build successful.
🟢 2024-11-05 11:14:41 UTC ydbd size 2.8 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 07eddfc merge: 79ac3e3 diff diff %
ydbd size 3 039 387 496 Bytes 3 039 388 984 Bytes +1.5 KiB +0.000%
ydbd stripped size 481 621 752 Bytes 481 621 816 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

⚪ 2024-11-05 10:14:56 UTC Pre-commit check linux-x86_64-release-asan for 79ac3e3 has started.
⚪ 2024-11-05 10:15:06 UTC Artifacts will be uploaded here
⚪ 2024-11-05 10:18:04 UTC ya make is running...
🟡 2024-11-05 11:21:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9043 8974 0 29 9 31

🟢 2024-11-05 11:22:30 UTC Build successful.
🟢 2024-11-05 11:22:59 UTC ydbd size 5.7 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 07eddfc merge: 79ac3e3 diff diff %
ydbd size 6 150 390 200 Bytes 6 150 391 752 Bytes +1.5 KiB +0.000%
ydbd stripped size 1 535 131 728 Bytes 1 535 132 560 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) November 5, 2024 13:07
@adameat adameat merged commit 4d16fd9 into ydb-platform:main Nov 5, 2024
11 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 6, 2024
Merged
@shnikd shnikd mentioned this pull request Nov 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 13, 2024
Merged
adameat added a commit to adameat/ydb that referenced this pull request Nov 14, 2024
@adameat
fix crash in storage/groups (ydb-platform#11268)
173b4bd
@adameat adameat deleted the fix-double-donors-crash branch November 14, 2024 09:51
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Merged
adameat added a commit to adameat/ydb that referenced this pull request Jan 13, 2025
@adameat
fix crash in storage/groups (ydb-platform#11268)
37e7b2a
@adameat adameat mentioned this pull request Jan 13, 2025
Merged
adameat added a commit that referenced this pull request Jan 13, 2025
@adameat
fix crash in storage/groups (#11268) (#13329)
7ef8e47
zinal pushed a commit to zinal/ydb that referenced this pull request Feb 9, 2025
@adameat @zinal
fix crash in storage/groups (ydb-platform#11268) (ydb-platform#13329)
a528230
zinal pushed a commit to zinal/ydb that referenced this pull request Feb 9, 2025
@adameat @zinal
fix crash in storage/groups (ydb-platform#11268) (ydb-platform#13329)
5879830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru alexvru approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crash in storage/groups handler
2 participants
@adameat @alexvru