[READY] Revert #1275 #1343
Merged
[READY] Revert #1275 #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d958336 to
95e5707
Compare
PR ycm-core#1275 broke GoTo in python in more ways than one. See: - ycm-core/YouCompleteMe#3458 - ycm-core#1341 Changes in the behaviour: - GoTo, GoToDefinition and GoToDeclaration now do what GoToType used to do. - We don't expose jedi's `goto_assignments` which can be useful, but we do have GoToReferences that calls jedi's `usages()`. - This means that `GoTo` on `self.x` will now jump to the definition of the type of `x`, while `GoToReferences` will do what is expected. - The `goto_usages` for this case returns "weird" locations, see ycm-core#1341 for details.
Codecov Report
@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
- Coverage 97.17% 97.16% -0.02%
==========================================
Files 96 96
Lines 7481 7446 -35
Branches 175 153 -22
==========================================
- Hits 7270 7235 -35
Misses 170 170
Partials 41 41 |
puremourning
approved these changes
Oct 19, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: 1 of 2 LGTMs obtained
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1275 broke GoTo in python in more ways than one. See:
Changes in the behaviour:
do.
goto_assignmentswhich can be useful, but wedo have GoToReferences that calls jedi's
usages().GoToonself.xwill now jump to the definitionof the type of
x, whileGoToReferenceswill do what is expected.goto_usagesfor this case returns "weird" locations, see PR #1275 broke GoTo for member functions #1341for details.
There's a test for member function access that was broken before.
This change is