Skip to content

[READY] Set up CI with Azure Pipelines #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019
Merged

[READY] Set up CI with Azure Pipelines #1241

merged 1 commit into from
May 7, 2019

Conversation

Valloric
Copy link
Member

@Valloric Valloric commented May 1, 2019

This change is Reviewable

@micbou micbou force-pushed the azure-pipelines branch 2 times, most recently from 4de86e6 to 3319a2a Compare May 2, 2019 00:25
@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #1241 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
- Coverage   97.38%   97.23%   -0.16%     
==========================================
  Files          96       95       -1     
  Lines        7240     7497     +257     
  Branches        0      153     +153     
==========================================
+ Hits         7051     7290     +239     
+ Misses        189      169      -20     
- Partials        0       38      +38

@micbou micbou force-pushed the azure-pipelines branch 4 times, most recently from ecff3ec to 819339e Compare May 2, 2019 12:35
Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 22 files at r1, 4 of 6 files at r2, 5 of 5 files at r3.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @Valloric)


azure-pipelines.yml, line 99 at r3 (raw file):

    matrix:
      'Python 3.7 64-bit':
        YCM_PYTHON_INSTALLER_URL: 'https://www.python.org/ftp/python/3.7.3/python-3.7.3-amd64.exe'

We can't use the UsePythonVersion here either ?


azure-pipelines.yml, line 127 at r3 (raw file):

    matrix:
      'Python 2.7 64-bit':
        YCM_PYTHON_INSTALLER_URL: 'https://www.python.org/ftp/python/2.7.16/python-2.7.16.amd64.msi'

I wasn't able to find any suggestion that azure pipelines support a cache. For all our other CI we cache certain directories to prevent constantly downloading (like lib clang).

Were you able to find any cache support ?

Copy link
Collaborator

@micbou micbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 22 files at r1, 6 of 6 files at r2, 3 of 5 files at r3.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @puremourning)


azure-pipelines.yml, line 99 at r3 (raw file):

Previously, puremourning (Ben Jackson) wrote…

We can't use the UsePythonVersion here either ?

Not for this image and I wanted to use the same script for both Windows images.


azure-pipelines.yml, line 127 at r3 (raw file):

Previously, puremourning (Ben Jackson) wrote…

I wasn't able to find any suggestion that azure pipelines support a cache. For all our other CI we cache certain directories to prevent constantly downloading (like lib clang).

Were you able to find any cache support ?

AFAIK, it's not yet supported. I am not too worried though as the build times are still reasonable.

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we got partial line coverage back.

:lgtm: but I won't trigger zzbot, because there's no [READY] tag.

Reviewable status: :shipit: complete! 2 of 2 LGTMs obtained (waiting on @puremourning)

@micbou micbou changed the title Set up CI with Azure Pipelines [READY] Set up CI with Azure Pipelines May 6, 2019
@micbou micbou force-pushed the azure-pipelines branch from 819339e to 3edc1bb Compare May 7, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants