-
Notifications
You must be signed in to change notification settings - Fork 774
[READY] Set up CI with Azure Pipelines #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4de86e6
to
3319a2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1241 +/- ##
==========================================
- Coverage 97.38% 97.23% -0.16%
==========================================
Files 96 95 -1
Lines 7240 7497 +257
Branches 0 153 +153
==========================================
+ Hits 7051 7290 +239
+ Misses 189 169 -20
- Partials 0 38 +38 |
ecff3ec
to
819339e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 22 files at r1, 4 of 6 files at r2, 5 of 5 files at r3.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @Valloric)
azure-pipelines.yml, line 99 at r3 (raw file):
matrix: 'Python 3.7 64-bit': YCM_PYTHON_INSTALLER_URL: 'https://www.python.org/ftp/python/3.7.3/python-3.7.3-amd64.exe'
We can't use the UsePythonVersion here either ?
azure-pipelines.yml, line 127 at r3 (raw file):
matrix: 'Python 2.7 64-bit': YCM_PYTHON_INSTALLER_URL: 'https://www.python.org/ftp/python/2.7.16/python-2.7.16.amd64.msi'
I wasn't able to find any suggestion that azure pipelines support a cache. For all our other CI we cache certain directories to prevent constantly downloading (like lib clang).
Were you able to find any cache support ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 22 files at r1, 6 of 6 files at r2, 3 of 5 files at r3.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @puremourning)
azure-pipelines.yml, line 99 at r3 (raw file):
Previously, puremourning (Ben Jackson) wrote…
We can't use the UsePythonVersion here either ?
Not for this image and I wanted to use the same script for both Windows images.
azure-pipelines.yml, line 127 at r3 (raw file):
Previously, puremourning (Ben Jackson) wrote…
I wasn't able to find any suggestion that azure pipelines support a cache. For all our other CI we cache certain directories to prevent constantly downloading (like lib clang).
Were you able to find any cache support ?
AFAIK, it's not yet supported. I am not too worried though as the build times are still reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we got partial line coverage back.
but I won't trigger zzbot, because there's no
[READY]
tag.
Reviewable status:
complete! 2 of 2 LGTMs obtained (waiting on @puremourning)
This change is