Current coverage is 92.69% (diff: 100%)

Merging #687 into master will not change coverage

@@             master       #687   diff @@
==========================================
  Files            79         79          
  Lines          5258       5258          
  Methods         297        297          
  Messages          0          0          
  Branches        139        139          
==========================================
  Hits           4874       4874          
  Misses          329        329          
  Partials         55         55          

Powered by Codecov. Last update d19f9c5...04ff46d

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

.travis.yml, line 30 at r1 (raw file):

    - USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.6
    - USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7
    - USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=3.6

Not sure this is the best approach; the minimum py3 version we support is 3.3 and we want to ensure we work with that.

I believe @micbou was talking about bumping the Windows Python version for appveyor, not travis.

Comments from Reviewable

Python 3.6 extensions does not build with MSVC 11 so it is removed from build matrix.

Let's keep it in the build matrix with Python 3.5 for now. We'll remove it when we decide to drop its support. We should just leave a comment explaining why we don't test it with Python 3.6.

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

.travis.yml, line 30 at r1 (raw file):

Yes, the reason we prefer testing against the last version of Python on Windows is that, since there is no default version of Python installed on this platform, users are likely to download and install the last one so we want to be sure that it works on this version.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

.travis.yml, line 30 at r1 (raw file):

That makes sense. So we're on the same page that the travis file shouldn't be changed then.

Comments from Reviewable

Reviewed 2 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Thanks again!

@homu r+

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

📌 Commit 04ff46d has been approved by puremourning

Reviewed 2 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from Reviewable

⚡ Test exempted - status