Hmmm...

What's the behaviour of something like this:

== file1.py ==

FILE1='test'

== file2.py ==

from file1 import FILE1 as OBFUSCATED_NAME

def Test():
  print( "Test: {0}".format( OBFUSCATED_NAME )   

What does GoTo do for OBFUSCATED_NAME ? Does it jump to FILE1= in file1.py ? I somehow feel like that is less good than jumping to the as OBFUSCATED_NAME in the import.

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Current coverage is 93.42% (diff: 100%)

Merging #585 into master will not change coverage

@@             master       #585   diff @@
==========================================
  Files            41         41          
  Lines          3835       3835          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3583       3583          
  Misses          252        252          
  Partials          0          0          

Powered by Codecov. Last update 9e100a0...a3c3675

What does GoTo do for OBFUSCATED_NAME ? Does it jump to FILE1= in file1.py ?

As you suspected, it jumps to file1.py.

I somehow feel like that is less good than jumping to the as OBFUSCATED_NAME in the import.

Yes, it may be confusing to the user. I proposed this change because of this comment from Jedi author but I am now having some doubts about it. For this reason, I am changing the purpose of this PR to only update JediHTTP (we have two issue reports that depend on it: ycm-core/YouCompleteMe#2298 and ycm-core/YouCompleteMe#2365). We may reconsider the follow_imports option later.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Nice

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@homu r=puremourning

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

📌 Commit a3c3675 has been approved by puremourning

⚡ Test exempted - status