Cancel a download task in notification #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is ready, please resolve the conflict. |
|
Rebase done 💨 |
|
I tested it on my phone and some of my attempts to cancel the download didn't work. |
Is this can be reproduced or just randomly occurring bugs? I also encountered this bug but a clean re-install solves it, I think it's is the problem of debug variant |
xibr
reviewed
Aug 20, 2022
Co-authored-by: iBR <20098154+xibr@users.noreply.github.com>
xibr
approved these changes
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bumped up the version of Kotlin and Room, because I use an M1 macOS device to compile(needs Room > 2.4.0-alpha03).
Closes #52