-
Notifications
You must be signed in to change notification settings - Fork 44
Switch to yt-dlp #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to yt-dlp #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
@yausername Should the full_description.txt file be updated? before bump version! If yes, should it be like this or do you have another suggestion! diff --git a/fastlane/metadata/android/en-US/full_description.txt b/fastlane/metadata/android/en-US/full_description.txt
index 5c62925..581ed77 100644
--- a/fastlane/metadata/android/en-US/full_description.txt
+++ b/fastlane/metadata/android/en-US/full_description.txt
@@ -1,12 +1,12 @@
-📀 Video downloader app powered by youtube-dl.
+📀 Video downloader app powered by yt-dlp (formerly youtube-dl).
🚀 Features
-* Download video/audio from 1000+ sites supported by youtube-dl.
-* Run custom youtube-dl commands.
-* Update youtube-dl version from settings.
+* Download video/audio from 1000+ sites supported by yt-dlp.
+* Run custom yt-dlp commands.
+* Update yt-dlp version from settings.
* Share link via other apps.
🔗 References
* dvd - https://github.com/yausername/dvd
* youtubedl-android - https://github.com/yausername/youtubedl-android
-* youtube-dl - https://github.com/ytdl-org/youtube-dl
+* yt-dlp - https://github.com/yt-dlp/yt-dlp (formerly youtube-dl - https://github.com/ytdl-org/youtube-dl) |
yeah this looks good to me. To release a new version on fdriod we would need to update this file as well. |
Well, I'll take a look at it tomorrow, if you have time, please feel free to do it.
it's not required. Edit: I have updated this file. |
Hi @yausername I have updated org.yausername.dvd.yml in the merge request!10208 But 0.1.3 hasn't been released yet, is there anything else to do? |
It can take some time for the release to happen because fdroid does some manual sigining process. We should wait a few more days. https://monitor.f-droid.org/builds/needsupdate |
Switch to yt-dlp Fixes #27