Skip to content

Conversation

xibr
Copy link
Collaborator

@xibr xibr commented Dec 11, 2021

Switch to yt-dlp Fixes #27

@xibr xibr marked this pull request as draft December 11, 2021 08:17
@xibr xibr marked this pull request as ready for review December 11, 2021 11:25
@xibr xibr requested a review from yausername December 11, 2021 11:25
Copy link
Owner

@yausername yausername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@xibr xibr merged commit 07050dd into yausername:master Dec 11, 2021
@xibr xibr deleted the switch-to-ytdlp branch December 11, 2021 14:09
@xibr
Copy link
Collaborator Author

xibr commented Dec 11, 2021

@yausername Should the full_description.txt file be updated? before bump version!

If yes, should it be like this or do you have another suggestion!

diff --git a/fastlane/metadata/android/en-US/full_description.txt b/fastlane/metadata/android/en-US/full_description.txt
index 5c62925..581ed77 100644
--- a/fastlane/metadata/android/en-US/full_description.txt
+++ b/fastlane/metadata/android/en-US/full_description.txt
@@ -1,12 +1,12 @@
-📀 Video downloader app powered by youtube-dl.
+📀 Video downloader app powered by yt-dlp (formerly youtube-dl).
 
 🚀 Features
-* Download video/audio from 1000+ sites supported by youtube-dl.
-* Run custom youtube-dl commands.
-* Update youtube-dl version from settings.
+* Download video/audio from 1000+ sites supported by yt-dlp.
+* Run custom yt-dlp commands.
+* Update yt-dlp version from settings.
 * Share link via other apps.
 
 🔗 References
 * dvd - https://github.com/yausername/dvd
 * youtubedl-android - https://github.com/yausername/youtubedl-android
-* youtube-dl - https://github.com/ytdl-org/youtube-dl
+* yt-dlp - https://github.com/yt-dlp/yt-dlp (formerly youtube-dl - https://github.com/ytdl-org/youtube-dl)

@yausername
Copy link
Owner

yeah this looks good to me. To release a new version on fdriod we would need to update this file as well.
I'm guessing this is a breaking change and people who upgrade from previous versions might have to clear data first. If that's the case, it might be good to also add a changelog file for the new version as described in the fastlane section here. In the changelog file we can say that users need to uninstall pervious version or clear data for this update to work.

@xibr
Copy link
Collaborator Author

xibr commented Dec 11, 2021

To release a new version on fdriod we would need to update this file as well.

Well, I'll take a look at it tomorrow, if you have time, please feel free to do it.

I'm guessing this is a breaking change and people who upgrade from previous versions might have to clear data first. If that's the case, it might be good to also add a changelog file for the new version as described in the fastlane section here.

it's not required.

Edit: I have updated this file.

@xibr
Copy link
Collaborator Author

xibr commented Dec 21, 2021

Hi @yausername I have updated org.yausername.dvd.yml in the merge request!10208 But 0.1.3 hasn't been released yet, is there anything else to do?

@yausername
Copy link
Owner

It can take some time for the release to happen because fdroid does some manual sigining process. We should wait a few more days. https://monitor.f-droid.org/builds/needsupdate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace youtube-dl with yt-dlp
2 participants