fix(context): break match loop when any viewer is matched #35

cnlangzi · 2025-02-05T02:21:19Z

Changed

Fixed

first matched viewer should be selected immediately .

Added

Tests

Tasks to complete before merging PR:

Ensure unit tests are passing. If not run make unit-test to check for any regressions 📋
Ensure lint tests are passing. if not run make lint to check for any issues
Ensure codecov/patch is passing for changes.

Summary by Sourcery

Bug Fixes:

Fixed a bug where the viewer matching loop did not terminate after finding a match.

sourcery-ai · 2025-02-05T02:21:23Z

Reviewer's Guide by Sourcery

The pull request modifies the view matching logic to exit the loop immediately after a viewer is successfully matched. This ensures that the first matched viewer is always selected, preventing potential issues where subsequent viewers might override the intended selection.

Sequence diagram for viewer matching process

sequenceDiagram
    participant C as Context
    participant V as Viewers
    C->>V: View(data, options)
    activate C
    loop For each viewer
        C->>V: Check viewer match
        alt Viewer matches
            V-->>C: Match successful
            Note right of C: Break loop immediately
        else No match
            V-->>C: Continue to next viewer
        end
    end
    alt Any viewer matched
        C-->>C: Process matched viewer
    else No viewer matched
        C-->>C: Handle no match case
    end
    deactivate C

File-Level Changes

Change	Details	Files
Modified view matching logic to exit the loop immediately after a viewer is successfully matched.	Added a break statement to exit the loop when a viewer is matched.	`context.go`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @cnlangzi - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

deepsource-io · 2025-02-05T02:22:07Z

Here's the code health analysis summary for commits 2eed869..7a8dab1. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Go	✅ Success		View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

codecov · 2025-02-05T02:22:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (2eed869) to head (7a8dab1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   90.99%   91.01%   +0.01%     
==========================================
  Files          37       37              
  Lines        1333     1335       +2     
==========================================
+ Hits         1213     1215       +2     
  Misses         83       83              
  Partials       37       37

Flag	Coverage Δ
Unit-Tests	`91.01% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix(context): break match loop when any viewer is matched

7a8dab1

sourcery-ai bot reviewed Feb 5, 2025

View reviewed changes

cnlangzi merged commit b5c1aac into main Feb 5, 2025
7 checks passed

cnlangzi deleted the fix/viewer_match branch February 5, 2025 02:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(context): break match loop when any viewer is matched #35

fix(context): break match loop when any viewer is matched #35

Uh oh!

cnlangzi commented Feb 5, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Feb 5, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

deepsource-io bot commented Feb 5, 2025

Analysis Summary

Uh oh!

codecov bot commented Feb 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix(context): break match loop when any viewer is matched #35

fix(context): break match loop when any viewer is matched #35

Uh oh!

Conversation

cnlangzi commented Feb 5, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changed

Fixed

Added

Tests

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

Sequence diagram for viewer matching process

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

deepsource-io bot commented Feb 5, 2025

Analysis Summary

Uh oh!

codecov bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

cnlangzi commented Feb 5, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Feb 5, 2025 •

edited

Loading

codecov bot commented Feb 5, 2025 •

edited

Loading