feat(viewer): added StringViewer #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a new Class diagram for StringViewer implementationclassDiagram
class StringViewer {
+MimeType() *MimeType
+Render(w http.ResponseWriter, r *http.Request, data any) error
}
class MimeType {
+Type string
+SubType string
}
StringViewer ..> MimeType : uses
note for StringViewer "Renders data as plain text"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Here's the code health analysis summary for commits Analysis Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 90.17% 90.25% +0.07%
==========================================
Files 34 35 +1
Lines 1221 1231 +10
==========================================
+ Hits 1101 1111 +10
Misses 83 83
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey @cnlangzi - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
viewer_string.go
Outdated
| return nil | ||
| } | ||
|
|
||
| w.Header().Add("Content-Type", "text/plain; charset=utf-8") |
There was a problem hiding this comment.
suggestion: Use Header().Set() instead of Add() for Content-Type to prevent multiple header values
Header().Add() can result in multiple Content-Type headers if one already exists. Since Content-Type should only have one value, Header().Set() would be more appropriate.
Suggested change
| w.Header().Add("Content-Type", "text/plain; charset=utf-8") | |
| w.Header().Set("Content-Type", "text/plain; charset=utf-8") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Fixed
Added
StringViewerTests
Tasks to complete before merging PR:
make unit-testto check for any regressions 📋make lintto check for any issuesSummary by Sourcery
New Features:
StringViewerthat renders data as a string.