fix(context): specified viewer should take precedence over first one #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request modifies the view selection logic to prioritize a specified viewer over the first available viewer when handling requests. It also includes new test cases to verify the correct behavior of the view selection logic. Sequence diagram for viewer selection logicsequenceDiagram
participant C as Context
participant V as Viewers
Note over C: View method called with name
C->>C: getViewer(name)
alt Viewer found by name and mime matches
C-->>V: Return named viewer
else No named viewer or mime mismatch
loop For each Accept header
C->>V: Check viewers for mime match
alt Mime match found
V-->>C: Return matching viewer
end
end
alt No matches found
alt Named viewer exists
C-->>V: Use named viewer as fallback
else No named viewer
C-->>V: Use first viewer as fallback
end
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @cnlangzi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding documentation comments to explain the viewer precedence rules in the Context.View() and getViewer() methods
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| v = c.Routing.Viewers[0] // pickup first viewer as default | ||
| if !ok { | ||
| if v == nil { | ||
| v = c.Routing.Viewers[0] // use the first viewer as a fallback when no viewer is matched or specified by name |
There was a problem hiding this comment.
issue: This could panic if Routing.Viewers is empty
Add a check for len(c.Routing.Viewers) > 0 before accessing the first element to prevent a potential panic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 90.15% 90.17% +0.01%
==========================================
Files 34 34
Lines 1219 1221 +2
==========================================
+ Hits 1099 1101 +2
Misses 83 83
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Fixed
Added
Tests
Tasks to complete before merging PR:
make unit-testto check for any regressions 📋make lintto check for any issuesSummary by Sourcery
Bug Fixes: