Skip to content

fix(htmx): added TestHtmxWriteHeader #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2025
Merged

fix(htmx): added TestHtmxWriteHeader #16

merged 2 commits into from
Jan 4, 2025

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Jan 4, 2025 •
edited
Loading

Changed

Fixed

Added

  • added unit tests: TestHtmxWriteHeader

Tests

Tasks to complete before merging PR:

  • Ensure unit tests are passing. If not run make unit-test to check for any regressions 📋
  • Ensure lint tests are passing. if not run make lint to check for any issues
  • Ensure codecov/patch is passing for changes.

Summary by Sourcery

Tests:

  • Add a new unit test TestHtmxWriteHeader to verify the correct behavior of the WriteHeader function in various scenarios.

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Jan 4, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request introduces a new unit test, TestHtmxWriteHeader, to verify the functionality of writing HTMX headers with various data types. Additionally, the pull request template has been updated to include a new section for added features, improving clarity and organization.

Sequence diagram for HTMX header writing test flow

sequenceDiagram
    participant Test as TestHtmxWriteHeader
    participant HTMX as HTMX Handler
    participant Header as HTTP Header

    Test->>HTMX: Write HTMX Header
    HTMX->>Header: Set Header Value
    Note over Header: Validates different data types
    Header-->>HTMX: Header Set
    HTMX-->>Test: Verification Complete
Loading

File-Level Changes

Change Details Files
Added a new unit test for the HTMX header writing functionality.
  • Created a new test file for HTMX related tests.
  • Implemented TestHtmxWriteHeader to test writing headers with different data types.
  • Used httptest to create a test server and client for HTTP requests.
  • Verified header values for string, integer, and custom header types using assertions.
 ext/htmx/htmx_test.go
Updated the pull request template to include a new section for added features.
  • Renamed 'Changes' to 'Changed' and 'Fixes' to 'Fixed'.
  • Added a new section 'Added' in the template.
 PULL_REQUEST_TEMPLATE.md
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 4, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR description mentions 'TestHtmlWriteHeader' but the actual test is named 'TestHtmxWriteHeader'. Please update the description to match the implementation.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (3b5446c) to head (f4501c7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   88.08%   88.86%   +0.78%     
==========================================
  Files          26       26              
  Lines        1024     1024              
==========================================
+ Hits          902      910       +8     
+ Misses         87       79       -8     
  Partials       35       35
Flag Coverage Δ
Unit-Tests 88.86% <ø> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Jan 4, 2025

Here's the code health analysis summary for commits 3b5446c..f4501c7. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cnlangzi cnlangzi merged commit 56774b8 into main Jan 4, 2025
7 checks passed
@cnlangzi cnlangzi deleted the fix/htmx_tests branch January 4, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cnlangzi