Skip to content

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Aug 11, 2025

Changed

Fixed

Added

Tests

Tasks to complete before merging PR:

  • Ensure unit tests are passing. If not run make unit-tests to check for any regressions 📋
  • Ensure lint tests are passing. if not run make lint to check for any issues
  • Ensure codecov/patch is passing for changes.

Summary by Sourcery

Use time.Sleep instead of a time.Ticker for the SSE server health check to fix CPU usage, introduce a configurable ClientTimeout, and rename/refactor the health check method and constructor.

New Features:

  • Add ClientTimeout constant and clientTimeout field to configure SSE client timeouts

Bug Fixes:

  • Replace ticker-based health check with Sleep to reduce CPU usage

Enhancements:

  • Rename startHealthCheck to KeepAlive and refactor Server constructor for context initialization

Chores:

  • Reformat import statements in option.go

Copy link

sourcery-ai bot commented Aug 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR refactors the SSE server’s health-check loop to use time.Sleep instead of a ticker (reducing CPU usage), adds a configurable client timeout, and cleans up server initialization and imports.

Class diagram for updated Server struct and KeepAlive method

classDiagram
    class Server {
        +map[string]*Client clients
        +map[string]int conns
        +context.Context ctx
        +context.CancelFunc cancel
        +time.Duration clientTimeout
        +KeepAlive()
    }
    class Client
    Server --> Client : manages
Loading

Class diagram for Option type and usage

classDiagram
    class Option {
        <<function>>
        +apply(*Server)
    }
    Option --> Server : modifies
Loading

File-Level Changes

Change Details Files
Introduce configurable client timeout
  • Defined ClientTimeout variable
  • Added clientTimeout field assignment in New()
  • Moved context.WithCancelCause call after server struct initialization
ext/sse/server.go
Refactor health-check loop to use time.Sleep
  • Renamed startHealthCheck to KeepAlive
  • Removed time.NewTicker and ticker.Stop
  • Replaced ticker.C case with default + time.Sleep using half timeout
ext/sse/server.go
Clean up imports in option.go
  • Converted single import to import block
  • Added grouping parentheses
ext/sse/option.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

deepsource-io bot commented Aug 11, 2025

Here's the code health analysis summary for commits 6680222..3bb889f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@6680222). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage        ?   91.70%           
=======================================
  Files           ?       66           
  Lines           ?     2675           
  Branches        ?        0           
=======================================
  Hits            ?     2453           
  Misses          ?      192           
  Partials        ?       30           
Flag Coverage Δ
Unit-Tests 91.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cnlangzi cnlangzi merged commit 1ec2a84 into main Aug 11, 2025
7 checks passed
@cnlangzi cnlangzi deleted the fix/sse_cpu_issue branch August 11, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant