Fix the presence indicator not working anymore #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properly. Use last seen time to determine presence as the old way isn't working anymore.
|
Looks really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen in eg #1242 the presence indicator does not work currently. This is caused by a few different issues, for one they did some server-side changes to some object names, causing the initial presence loading to not work. They also completely removed the presence value from the server event, and it is instead replaced by a null. I fixed this by instead relying on the timestamp in that message, which will be checked against the self presence timestamp and if it's older than an offset (15 minutes currently because that seems to be what it is in the web app) the user will be marked as not present.