Favorite Servers #465
Favorite Servers #465
Conversation
|
Tinting the background of favorite servers looks pretty decent. |
|
Took me a good 10 seconds to notice it, make it more prominent! |
|
How about keeping the blue background and changing text color to yellow/gold? Yellow and blue go good together! The same color that @VelocityRa used in the Spectator list sounds good to me. Perhaps a bit darker. Also, yellow is commonly associated with the "star" of favorites |
|
Here you go: |
|
Just say when it's ready as it is now marked as [WIP]. Looks really good. |
|
If nobody has any suggestions it's ready. |
|
Me and @VelocityRa log in almost everyday to ensure tagging is correct. But I have to agree, it's a pain in the ass for people wanting to submit a pull request that they can't change their own tags unless they're a collaborator. The suggestion of modifying the title (or just the contents, really, it's rare to have more than 4 issues pull requests open and it's fast to open and see their status) sounds good to me. Or we can keep both. @VelocityRa what do you think of the |
| @@ -59,6 +61,8 @@ namespace spades { | |||
| int GetPing() { return ping; } | |||
| int GetNumPlayers() { return numPlayers; } | |||
| int GetMaxPlayers() { return maxPlayers; } | |||
| bool IsFavorite() { return favorite; } | |||
| bool SetFavorite(bool favorite) { this->favorite = favorite; } | |||
There was a problem hiding this comment.
return is missing in this non-void function. (specified by C++ spec as undefined behavior)
There was a problem hiding this comment.
Oops it's not only undefined behavior, it also makes no sense.
yvt requested changes. Also, it was wrong of my part to approve them, I didn't even test them.
|
@feikname @theunknownxy WIP: sounds good to me. Let's ditch the "PR:work-in-progress" label. |
|
@VelocityRa done. |
|
Thank you for fix. Looks very good. |
This is a implementation of #436.
TODO