feat: AWS S3 sync compatible exclude patterns #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Port Python fnmatch module to Go for AWS S3 sync compatibility - Implement full Unix shell wildcard pattern matching - * matches everything including path separators (Python behavior) - Add comprehensive tests and benchmarks - Include proper PSF-2.0 license attribution Co-Authored-By: Claude <noreply@anthropic.com>
- Replace doublestar with fnmatch for pattern matching - * now matches path separators (AWS S3 sync behavior) - Update tests to verify AWS S3 sync compatibility - Remove doublestar dependency Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
- Add LICENSE-PSF file with full PSF-2.0 license text - Add NOTICE file documenting changes from original Python code - Update main LICENSE file to reference PSF-2.0 for fnmatch code - Update README with license information - Update fnmatch.go header with proper copyright attribution Co-Authored-By: Claude <noreply@anthropic.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
*now matches path separators, matching AWS CLI behaviorDetails
Problem
The current exclude pattern implementation using doublestar follows standard Unix glob behavior where
*does not match path separators. This differs from AWS S3 sync which uses Python fnmatch where*matches everything including/.For example:
--exclude "_next/*"only excludes_next/file.txt--exclude "_next/*"excludes_next/file.txt,_next/subdir/file.txt, etc.Solution
Ported Python fnmatch module to Go, maintaining the exact pattern matching behavior for AWS S3 sync compatibility.
Changes
Breaking Change
*now match across directory boundaries.Test plan
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com