fix: normalize S3 URI prefix to handle trailing slashes consistently #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When syncing files to S3, URIs with trailing slashes (e.g.,
s3://bucket/prefix/
) were not handled consistently with URIs without trailing slashes (e.g.,s3://bucket/prefix
). This caused incorrect path comparisons during sync operations, as documented in the investigation notes.Solution
path.Clean()
to normalize prefixes, removing trailing slashes and handling multiple slashestrimS3KeyPrefix()
function to centralize prefix trimming logicTest plan
Related Issues
Fixes the path comparison issues documented in the checksum investigation.
🤖 Generated with Claude Code