[ie/appleconnect] Rework extractor #13229
Open
+96
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
May 27, 2025
seproDev
reviewed
Jul 19, 2025
|
if |
|
|
seproDev
reviewed
Jul 27, 2025
Comment on lines
+101
to
+104
| } | ||
| if not height: | ||
| fmt['width'] = None | ||
| formats.append(fmt) |
There was a problem hiding this comment.
So we don't need to remove the width
Suggested change
| } | |
| if not height: | |
| fmt['width'] = None | |
| formats.append(fmt) | |
| }) |
| 'assetTokens', {dict.items}, lambda _, v: url_or_none(v[1]), | ||
| )): | ||
| height = self._QUALITIES.get(format_id) | ||
| fmt = { |
There was a problem hiding this comment.
Suggested change
| fmt = { | |
| formats.append({ |
| for format_id, src_url in traverse_obj(attributes, ( | ||
| 'assetTokens', {dict.items}, lambda _, v: url_or_none(v[1]), | ||
| )): | ||
| height = self._QUALITIES.get(format_id) |
There was a problem hiding this comment.
Could even inline this
Suggested change
| height = self._QUALITIES.get(format_id) |
| fmt = { | ||
| 'ext': 'm4v', | ||
| 'format_id': format_id, | ||
| 'height': height, |
There was a problem hiding this comment.
Suggested change
| 'height': height, | |
| 'height': self._QUALITIES.get(format_id), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
simple broken IE rework (not marked as
_WORKING = False)Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check those that apply and remove the others:
What is the purpose of your pull request? Check those that apply and remove the others: