refactor: extract common jwt_is_expired to utils
#12630
Open
+38
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
Mar 16, 2025
_is_jwt_token_expired to InfoExtractorjwt_is_expired to utils
bashonly
requested changes
Mar 16, 2025
bashonly
reviewed
Mar 16, 2025
bashonly
reviewed
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
As mentioned by @seproDev in #12479 (comment) & #12479 (comment),
_is_jwt_token_expiredshould be in a common place so that it can be used by all extractors without needing to re-invent the wheel.CC/ @bashonly
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check those that apply and remove the others:
What is the purpose of your pull request? Check those that apply and remove the others: