[core] Calculate date by strftime_or_none; fix seconds in datetime_round
#11902
+31
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_round` - Negative datetime is not acceptable on Windows. - Scale the timestamp up 1000000 times to calculate milliseconds.
8 tasks
More readable. Since Python 3.6: https://docs.python.org/3/library/functions.html#int Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
seproDev
approved these changes
Jul 22, 2025
| @@ -1367,22 +1367,30 @@ def datetime_add_months(dt_, months): | |||
| return dt_.replace(year, month, day) | |||
|
|
|||
|
|
|||
| def datetime_from_timestamp(timestamp): | |||
| # Calling dt.datetime.fromtimestamp with negative timestamps throws error in Windows | |||
| # Ref: https://github.com/yt-dlp/yt-dlp/issues/5185, https://github.com/python/cpython/issues/94414, | |||
There was a problem hiding this comment.
Suggested change
| # Ref: https://github.com/yt-dlp/yt-dlp/issues/5185, https://github.com/python/cpython/issues/94414, | |
| # Ref: https://github.com/yt-dlp/yt-dlp/issues/5185, https://github.com/python/cpython/issues/81708, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
We have already applied some patches for this bug:
Now it's time to get the K.O.!
Refs:
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?