Mark plyr progress bars as removed/deprecated #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #139 +/- ##
===========================================
+ Coverage 86.76% 86.83% +0.07%
===========================================
Files 33 33
Lines 3898 3866 -32
===========================================
- Hits 3382 3357 -25
+ Misses 516 509 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Misses are mostly the warnings and some boilerplate code. I'm happy with the changes. |
|
Thank you for your contributions @MichaelChirico. I was able to drop the dependency on plyr (and doParallel as a side effect). |
|
Excellent, thank you for your careful reviews and additional help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving as draft for now while the other related PRs are sorted out, it will be easier to figure out what to do with these progress bars then.