Also skip if missing ggplot2 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #114 +/- ##
===========================================
- Coverage 85.65% 85.63% -0.03%
===========================================
Files 33 33
Lines 3569 3569
===========================================
- Hits 3057 3056 -1
- Misses 512 513 +1 ☔ View full report in Codecov by Sentry. |
|
Hi Michael, thanks a lot for the pull request! That's a good catch. Tests should definitely not fail if ggplot2 is unavailable. I guess technically some of the tests using this function only use the base plot engine, but that should be good enough. I'll merge it asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ggplot2 is only Suggests for vdiffr, so skipping for vdiffr is not sufficient to ensure doppelganger tests run.