Skip to content

FEAT: [embedding] add support for jina-embeddings-v4 model #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 19, 2025

Conversation

Minamiyama
Copy link
Collaborator

add support for jina-embeddings-v4 model

Add support for jina-embeddings-v4 model with 2048 dimensions and 32768 max tokens
Update transformers package version in both model_spec.json and model_spec_modelscope.json to ensure compatibility and security fixes
…ddings

Add check for tokenizer attribute before assignment to prevent errors with models that don't have a tokenizer. Also extend CLIP model check to include Jina Embeddings v4 for proper base64 encoding handling.
@XprobeBot XprobeBot added this to the v1.x milestone Jul 19, 2025
Extend the token counting logic to support Jina Embeddings v4 models, similar to how CLIP models are handled
# Conflicts:
#	xinference/model/embedding/model_spec.json
#	xinference/model/embedding/model_spec_modelscope.json
#	xinference/model/embedding/sentence_transformers/core.py
@Minamiyama Minamiyama marked this pull request as ready for review July 19, 2025 09:45
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit c889075 into xorbitsai:main Jul 19, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants