Refactoring data processing #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new `make_dataset_args` in `settings.json` to support dataset creation with a specified processing method. - Updated `load_config` function in `config.py` to handle the new `make_dataset` argument type, allowing for flexible configuration loading. - Improved file handling in `config.py` by specifying UTF-8 encoding when reading `settings.json`.
- Added `commentjson` to `requirements.txt` for improved JSON handling. - Enhanced `settings.json` with a new `prefer_comma` option for chat preferences. - Refactored `csv_to_json.py` to improve data processing logic and added comments for clarity. - Updated `qa_generator.py` to include data validation and filtering based on blocked words. - Modified `strategies.py` to clarify the time window parameter and renamed a strategy class for better understanding. - Changed JSON loading in `config.py` to use `commentjson` for better compatibility with comments in JSON files.
- Updated `settings.json` to include a new `conversation_strategy` and `time_window` for improved conversation handling. - Refactored `qa_generator.py` to initialize conversation strategies based on the new configuration options. - Modified `strategies.py` to improve type hints and clarify strategy implementations for conversation management.
…转换脚本；重构qa_generator.py
…or.py以支持新的消息处理策略，优化数据处理逻辑，更新测试用例以适应新功能。
…参数，更新qa_generator.py以支持新的消息处理逻辑，删除旧的测试文件test_old_csv_to_json copy.py并更新相关测试用例。
make_dataset/qa_generator.py
Outdated
| import pandas as pd | ||
| import json | ||
|
|
||
| current_dir = os.path.dirname(p=os.path.abspath(__file__)) |
There was a problem hiding this comment.
The use of the keyword argument 'p=' in os.path.dirname is invalid; please change it to use os.path.dirname(os.path.abspath(file)) instead.
Suggested change
| current_dir = os.path.dirname(p=os.path.abspath(__file__)) | |
| current_dir = os.path.dirname(os.path.abspath(__file__)) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
数据处理第一次重构