Skip to content

Fix: safely split command strings #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix: safely split command strings #340

merged 1 commit into from
Feb 19, 2024

Conversation

xjasonlyu
Copy link
Owner

@xjasonlyu xjasonlyu commented Feb 19, 2024 •
edited
Loading

For tun-pre-up and tun-post-up options, this PR fixes the issue that would cut quoted args into multiple args.

e.g. before cutting sh -c 'ls /':

["sh", "-c", "'ls", "/'"]

after:

["sh", "-c", "ls /"]

@xjasonlyu xjasonlyu merged commit 8653c18 into main Feb 19, 2024
@xjasonlyu xjasonlyu deleted the cmd branch February 19, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xjasonlyu