Fix typos #794
Closed
Fix typos #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -575,10 +575,10 @@ class pisaTagPDFPAGENUMBER(pisaTag): | |||
|
|
|||
| def start(self, c: pisaContext) -> None: # noqa: PLR6301 | |||
| flow = PageNumberFlowable() | |||
| pn = c.addPageNumber(flow) | |||
| pageNumber = c.addPageNumber(flow) | |||
There was a problem hiding this comment.
Are the previous names of these variables really typos?
There was a problem hiding this comment.
Sorry I should have mentioned this in the PR.
It got flagged as a false positive of on and I figured having a descriptive variable name is good practice.
I'm happy to change it back or to something like number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR includes typo fixes found in this project
Proposed changes
Most are simple documentation corrections however there are a couple of user facing changes:
pisaErrorDocument()corrects a typo ofoccured->occurredin its outputpisaLinkLoader --systemcommand outputsSYSTEM INFORMATIONS->SYSTEM INFORMATIONThese are both minor changes but I guess someone could be parsing the output of them.