-
-
Notifications
You must be signed in to change notification settings - Fork 656
Update import for breaking changes in python-bidi 0.5.0 #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for reporting and fixing this issue! 👍
Co-authored-by: Timo Brembeck <github@timo.brembeck.email>
@@ -22,7 +22,7 @@ | |||
import arabic_reshaper | |||
import reportlab | |||
import reportlab.pdfbase._cidfontdata | |||
from bidi.algorithm import get_display | |||
from bidi import get_display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be trivial to keep supporting older versions?
This pending change need to be merged ASAP, as its affecting the production |
Why can't you just downgrade to |
Thanks @stefan6419846 |
if you are using github actions, you can downgrade to version 0.4.2
|
Version 0.5.1 has been released to fix this for now, after this issue of |
Hello everyone, any predictions on when a fix for this problem will be released? |
Just use |
Like I mentioned in #766 (comment):
|
Short description
python-bidi 0.5.0 introduces a breaking change
Proposed changes
Update the import to fix the breaking change
Resolved issues
Fixes: #766