Skip to content

Update docker-compose.yml #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update docker-compose.yml #398

merged 1 commit into from
Oct 15, 2024

Conversation

andrew-farries
Copy link
Collaborator

Update docker-compose.yml

  • Remove redundant version field.
  • Change the port number
  • Change the image version to Postgres 17.
  • Use an anonymous volume so that it can be cleaned up with docker compose rm -v

Copy link
Member

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will te change in port impact docs? I guess it would require to manually change some URL?

@andrew-farries
Copy link
Collaborator Author

The docker compose setup isn't discussed in the docs, so no need to change anything.

@exekias
Copy link
Member

exekias commented Oct 15, 2024

I guess it still means we deviate from defaults? now setting a URL will be required for init and so, what's the rationale behind the port change?

@andrew-farries andrew-farries merged commit 00d492a into main Oct 15, 2024
72 checks passed
@andrew-farries andrew-farries deleted the update-compose-file branch October 15, 2024 09:56
@andrew-farries
Copy link
Collaborator Author

Sorry, didn't see your comment before I merged.

#402 changes the port back to 5432. The motivation was to avoid colliding with other existing Postgres instances that might be running, but changing the port here isn't the best way to solve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants