Add spinners and progress notifications to CLI output #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
andrew-farries
added a commit
that referenced
this pull request
Sep 26, 2023
Update to the latest version of `golangci-lint`. Also add an explicit `setup-go` step to the workflow before the `golangci-lint` step. Without this, `golangci-lint` seems to pick up the wrong Go version installed on the runners (see the list [here](https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#go)), causing it to fail when running against #139
Allow the `backfill` function to take callbacks and invoke them on every batch.
Allow the `Operation.Start` method to take an optional set of callbacks and pass the callbacks into the `backfill` function.
And pass them into the `Operation.Start` calls.
Add a spinner that shows progress updates on the status of any backfill operation performed by the start operation.
d9a3c20 to
2f3a171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spinners and progress notification to the CLI output.
The
startcommand has progress updates while the other commands just have their output displayed consistently with thestartcommand; no progress updates as these operations are expected to be short-running.Only the operations that perform backfills currently publish any progress updates as this is the longest running part of any operation.
start:
Screen.Recording.2023-09-26.at.15.18.38.mov
init
rollback
complete