Skip to content

Remove the --with-prefixes flag from the pull command #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

andrew-farries
Copy link
Collaborator

Remove the --with-prefixes flag from the pull command.

The --with-prefixes flag was a workaround for inferred migrations not being named in such a way that they would appear in the correct order when pulled. As of #899, inferred migrations are named correctly so that pgroll pull will put all migrations, including inferred migrations, in the correct order on disk.

@github-actions github-actions bot temporarily deployed to Docs Preview August 12, 2025 09:57 Inactive
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgroll/cmd 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgroll/cmd/pull.go 0.00% (ø) 42 (-4) 0 42 (-4)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@andrew-farries andrew-farries marked this pull request as ready for review August 12, 2025 10:01
@andrew-farries andrew-farries requested a review from kvch August 12, 2025 10:02
@andrew-farries andrew-farries merged commit b884976 into main Aug 12, 2025
30 checks passed
@andrew-farries andrew-farries deleted the remove-with-prefixes-flag branch August 12, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants