Skip to content

Disable pgformatter in make format #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Disable pgformatter in make format #949

merged 1 commit into from
Jul 11, 2025

Conversation

andrew-farries
Copy link
Collaborator

Temporarily remove the pgformatter step from make format because the backplane/pgformatter:latest image is broken and there is no way to pin to an older version:

Can be reproduced locally:

docker rmi backplane/pgformatter:latest 
make format

Uncaught exception: Uncaught exception: Uncaught exception: Uncaught exception: Possible precedence problem between ! and string eq at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/Beautify.pm line 510.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Possible precedence problem between ! and string eq at /usr/l"...) called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/Beautify.pm line 510
        require pgFormatter/Beautify.pm called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        pgFormatter::CLI::BEGIN() called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        eval {...} called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        require pgFormatter/CLI.pm called at /usr/local/bin/pg_format line 45
Compilation failed in require at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Uncaught exception: Possible precedence problem between ! and"...) called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        pgFormatter::CLI::BEGIN() called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        eval {...} called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        require pgFormatter/CLI.pm called at /usr/local/bin/pg_format line 45
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Uncaught exception: Uncaught exception: Possible precedence p"...) called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        require pgFormatter/CLI.pm called at /usr/local/bin/pg_format line 45
Compilation failed in require at /usr/local/bin/pg_format line 45.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Uncaught exception: Uncaught exception: Uncaught exception: P"...) called at /usr/local/bin/pg_format line 45
make: *** [format] Error 2

@andrew-farries
Disable pgformatter in make format
85fff0a 
Temporarily remove the pgformatter step from `make format` because the
backplane/pgformatter:latest image is broken and there is no way to pin
to an older version.
@github-actions github-actions bot temporarily deployed to Docs Preview July 11, 2025 08:24 Inactive
@andrew-farries andrew-farries marked this pull request as ready for review July 11, 2025 08:35
@andrew-farries andrew-farries requested a review from kvch July 11, 2025 08:35
@andrew-farries andrew-farries merged commit 0c66cb0 into main Jul 11, 2025
30 checks passed
@andrew-farries andrew-farries deleted the disable-pgformatter branch July 11, 2025 11:44
@andrew-farries andrew-farries mentioned this pull request Jul 18, 2025
Merged
andrew-farries added a commit that referenced this pull request Jul 21, 2025
@andrew-farries
Re-enable pgformatter (#952)
06346a6 
This reverts #949 

The issue was fixed upstream:
backplane/conex#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-farries @kvch