Recreate event trigger first in init.sql
#948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4eec661 to
544eb2a
Compare
544eb2a to
50860b2
Compare
kvch
approved these changes
Jul 11, 2025
Move event trigger creation to be the first thing that happens (after `pgroll` schema creation) in `init.sql`. Previous versions of `pgroll` used an event trigger that was incompatible with the latest version, causing errors on the upgrade path to `pgroll 0.14`. By moving event trigger creation to happen first during `init`, we ensure that the old event trigger installed by an older version of `pgroll` can't fire during the `init` of the new version.
50860b2 to
db34708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move event trigger creation to be the first thing that happens (after
pgrollschema creation) ininit.sql.Previous versions of
pgrollused an event trigger that was incompatible with the latest version, causing errors on the upgrade path topgroll 0.14. By moving event trigger creation to happen first duringinit, we ensure that the old event trigger installed by an older version ofpgrollcan't fire during theinitof the new version.