Return list of DBAction from Start
#944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e741e2 to
1968e8f
Compare
1968e8f to
9feb18a
Compare
andrew-farries
approved these changes
Jul 2, 2025
pkg/roll/execute.go
Outdated
| @@ -101,15 +101,20 @@ func (m *Roll) StartDDLOperations(ctx context.Context, migration *migrations.Mig | |||
| // execute operations | |||
| job := backfill.NewJob(m.schema, versionSchemaName) | |||
| for _, op := range migration.Operations { | |||
| task, err := op.Start(ctx, m.logger, m.pgConn, newSchema) | |||
| actions, task, err := op.Start(ctx, m.logger, m.pgConn, newSchema) | |||
There was a problem hiding this comment.
Rename task to something more specific like backfillTask.
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns adds a new return value to
Startto return the list ofDBActions. However, returning 3 values is too many, so in a follow-up PR I am combining the list ofDBActionsandbackfill.Taskinto the same data structure. The name is pending, my ideas so farStartSteporStartOperation. If you have a better name, I am open to using them.New data structure in a follow-up PR: