Skip to content

Turn Duplicator into a DBAction #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jun 27, 2025

This PR renames Duplicate to Execute, so Duplicator can be used as a DBAction.

Relates to #742

@github-actions github-actions bot temporarily deployed to Docs Preview June 27, 2025 10:05 Inactive
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgroll/pkg/migrations 75.29% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgroll/pkg/migrations/duplicate.go 92.80% (ø) 125 116 9
github.com/xataio/pgroll/pkg/migrations/op_alter_column.go 86.49% (ø) 111 96 15
github.com/xataio/pgroll/pkg/migrations/op_create_constraint.go 81.42% (ø) 113 92 21
github.com/xataio/pgroll/pkg/migrations/op_drop_constraint.go 84.00% (ø) 50 42 8
github.com/xataio/pgroll/pkg/migrations/op_drop_multicolumn_constraint.go 86.57% (ø) 67 58 9

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@kvch kvch requested a review from andrew-farries June 27, 2025 12:32
@kvch kvch changed the title Turn Duplicator into DBAction Turn Duplicator into a DBAction Jun 27, 2025
@kvch kvch merged commit bc40891 into main Jul 1, 2025
30 checks passed
@kvch kvch deleted the refactoring-dbaction-duplicate branch July 1, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants