Skip to content

Rename pgroll.internal GUC to pgroll.no_inferred_migrations #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

andrew-farries
Copy link
Collaborator

Rename the GUC that causes pgroll to ignore schema changes made by itself (ie don't create inferred migrations for them).

The new name better reflects its purpose, and allows us to document it externally as a way for other applications to have their own DDL ignored by pgroll.

Rename the GUC that causes `pgroll` to ignore schema changes made by
itself.

The new name better reflects its purpose, and allows us to document it
exernally as a way for other applications to have their own DDL ignored
by `pgroll`.
@github-actions github-actions bot temporarily deployed to Docs Preview June 24, 2025 08:41 Inactive
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgroll/pkg/roll 79.64% (-0.43%) 👎
github.com/xataio/pgroll/pkg/state 74.49% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgroll/pkg/roll/roll.go 76.09% (ø) 46 35 11
github.com/xataio/pgroll/pkg/state/state.go 69.86% (ø) 146 102 44

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@andrew-farries andrew-farries marked this pull request as ready for review June 24, 2025 08:51
@andrew-farries andrew-farries requested review from kvch and divyenduz June 24, 2025 08:51
@andrew-farries andrew-farries merged commit c3c73e4 into main Jun 24, 2025
30 checks passed
@andrew-farries andrew-farries deleted the rename-pgroll-internal branch June 24, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants